fix: capturing parent exception JsonException#832
Merged
Conversation
Contributor
sbansla
commented
May 5, 2026
- Fix when API returns null for integer fields (e.g., "code": null) in error responses.
|
kridai
approved these changes
May 5, 2026
There was a problem hiding this comment.
Pull request overview
This PR hardens error-response deserialization in Twilio REST clients so that malformed/unexpected JSON (including cases like integer fields returned as null) doesn’t escape as an unhandled JSON parsing/serialization exception, and instead falls back to existing error handling.
Changes:
- Broadened exception handling during
RestException.FromJson(...)parsing fromJsonReaderExceptiontoJsonException. - Broadened exception handling during
RestApiStandardException.FromJson(...)parsing fromJsonReaderExceptiontoJsonException. - Applied the same behavior consistently across the standard, no-auth, and orgs-token REST clients.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Twilio/Clients/TwilioRestClient.cs |
Catch JsonException during error payload parsing to prevent unhandled JSON exceptions and allow fallback behavior. |
src/Twilio/Clients/NoAuth/TwilioNoAuthRestClient.cs |
Same broadened JSON exception handling for the no-auth client error parsing path. |
src/Twilio/Clients/BearerToken/TwilioOrgsTokenRestClient.cs |
Same broadened JSON exception handling for the bearer-token orgs client error parsing path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


