Skip to content

chore: removed exception, it will be handled by downstream #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbansla merged 8 commits into from
Sep 29, 2025
Merged

chore: removed exception, it will be handled by downstream #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea928aa
chore: added App IEndpoint type
sbansla Aug 7, 2025
14d6ecb
Merge branch 'main' into add-app-endpoint-type
sbansla Sep 25, 2025
db5ce65
added null and empty check and added its test cases
sbansla Sep 25, 2025
2f31467
Merge branch 'add-app-endpoint-type' of https://github.com/twilio/twi…
sbansla Sep 25, 2025
8d79ca5
fixed null check
sbansla Sep 25, 2025
21f291a
using argument exception instead of custom exception, keeping excepti…
sbansla Sep 25, 2025
4f68e85
removed exception
sbansla Sep 29, 2025
74ede38
Merge branch 'main' into add-app-endpoint-type
sbansla Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Twilio/Types/App.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System;

namespace Twilio.Types
{
/// <summary>
Expand All @@ -17,11 +15,6 @@ public class App : IEndpoint
/// <param name="app">App name</param>
public App(string app)
{
if (string.IsNullOrEmpty(app))
{
throw new ArgumentException("Parameter 'app' cannot be null or empty.", nameof(app));
}

if (!app.ToLower().StartsWith(PREFIX))
{
app = PREFIX + app;
Expand Down
4 changes: 1 addition & 3 deletions test/Twilio.Test/Types/AppTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System;
using NUnit.Framework;
using Twilio.Exceptions;
using Twilio.Types;

namespace Twilio.Tests.Types
Expand All @@ -15,7 +14,6 @@ public void TestToString()
Assert.AreEqual("app:YOU", new App("YOU").ToString());
Assert.AreEqual("APP:HIM", new App("APP:HIM").ToString());
Assert.AreEqual("aPp:her", new App("aPp:her").ToString());
Assert.Throws<ArgumentException>(() => new App("").ToString());
Assert.AreEqual("app:AP12345?mycustomparam1=foo&mycustomparam2=bar", new App("app:AP12345?mycustomparam1=foo&mycustomparam2=bar").ToString());
Assert.AreEqual("app:AP12345?mycustomparam1=foo&mycustomparam2=bar", new App("AP12345?mycustomparam1=foo&mycustomparam2=bar").ToString());
}
Expand Down
Loading