Skip to content

chore: add correct .nupkg name to push signed package #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiwarishubham635 merged 2 commits into from
Apr 7, 2025
Merged

chore: add correct .nupkg name to push signed package #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adaf34e
chore: add correct .nupkg name to push signed package
tiwarishubham635 Apr 7, 2025
d91c891
chore: add correct .nupkg name to push signed package
tiwarishubham635 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ jobs:
uses: actions/setup-dotnet@v3
with:
global-json-file: global.json

# - name: Remove dotnet 7 and 8
# run: sudo rm -rf /usr/share/dotnet/sdk/{7*,8*}

- name: Get installed dotnet version
run: dotnet --version

- uses: actions/setup-java@v4
with:
distribution: 'zulu'
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
uses: sendgrid/dx-automator/actions/datadog-release-metric@main
env:
DD_API_KEY: ${{ secrets.DATADOG_API_KEY }}

code-signing:
runs-on: windows-latest
needs: [ deploy ]
Expand Down Expand Up @@ -174,8 +174,9 @@ jobs:
run: |
dotnet build -c Release
dotnet pack -c Release
nuget sign **/*.nupkg -Timestamper http://timestamp.digicert.com -outputdirectory .\NugetSigned -CertificateFingerprint ${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }} -HashAlgorithm SHA256 -Verbosity detailed -Overwrite
nuget push **/*.nupkg -ApiKey ${{ secrets.NUGET_API_KEY }} -Source https://api.nuget.org/v3/index.json -SkipDuplicate
echo "Twilio.${{ steps.variables.outputs.version }}.nupkg"
nuget sign Twilio.${{ steps.variables.outputs.version }}.nupkg -Timestamper http://timestamp.digicert.com -outputdirectory .\NugetSigned -CertificateFingerprint ${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }} -HashAlgorithm SHA256 -Verbosity detailed -Overwrite
nuget push Twilio.${{ steps.variables.outputs.version }}.nupkg -ApiKey ${{ secrets.NUGET_API_KEY }} -Source https://api.nuget.org/v3/index.json -SkipDuplicate

notify-on-failure:
name: Slack notify on failure
Expand Down
Loading