Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding support for net35 net462 and netstandard2.1 #738

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: adding support for net35 net462 and netstandard2.1 #738

merged 2 commits into from
Mar 11, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Mar 11, 2024 •
edited
Loading

Fixes

Adding back support for net35, net462, netstandard2.1

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sbansla sbansla changed the title adding support for net35 net462 and netstandard2.1 fix: adding support for net35 net462 and netstandard2.1 Mar 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tiwarishubham635
tiwarishubham635 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbansla sbansla merged commit 31dc0e3 into main Mar 11, 2024
10 checks passed
@sbansla sbansla deleted the add-backward-compatability branch March 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbansla @tiwarishubham635