Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handling number parameters serialization #659

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix: handling number parameters serialization #659

merged 1 commit into from
Dec 14, 2022

Conversation

AsabuHere
Copy link
Contributor

Closes

DII-792 Decimal conversion is not proper in v6 of twilio-csharp library
A short description of what this PR does.
Decimal conversion is not proper in v6 of twilio-csharp library

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@AsabuHere AsabuHere mentioned this pull request Dec 13, 2022
Merged
14 tasks
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sbansla sbansla changed the title fix : handling number parameters serialization fix: handling number parameters serialization Dec 14, 2022
@AsabuHere AsabuHere merged commit 7c93e33 into main Dec 14, 2022
@AsabuHere AsabuHere deleted the decimal_param_diff branch December 14, 2022 03:44
Swimburger pushed a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
@AsabuHere @Swimburger
handling number parameters (twilio#659)
d342a6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsabuHere @sbansla