Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Merging RC branch to main #645

Merged
merged 25 commits into from
Nov 15, 2022
Merged

feat!: Merging RC branch to main #645

merged 25 commits into from
Nov 15, 2022

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Nov 14, 2022 •
edited
Loading

Fixes

A short description of what this PR does.
Merging 6.0.0-rc branch to main with Breaking change
Changes made as per doc

  • PR is marked as feat! (Breaking Change)
  • Readme: Removed RC installation steps
  • Upgrade: Added steps to upgrade to 6.x.x from 5.x.x
  • Contributing: Edited heading "Found an issue" to identify oai generated files
  • Changes: Removed RC branch changes
  • Removed test/Twilio.Test/Rest package and included src/Twilio/Rest package from rc branch.
  • Included cluster test from rc branch

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

AsabuHere and others added 19 commits August 30, 2022 14:10
@AsabuHere
Sample commit
e5082d3
@rohith-prakash
test: Cluster test for csharp (#631)
2cd0d69 
test: added cluster tests
@AsabuHere
feat: Added steps to install RC version and updated major version (#637)
b040e23 
* deleting Rest folder inside test and updating build configuration file

* Updating major version and added steps to install RC version

* modifed version to mark as rc version
@sbansla
chore: ignore openapi autogenerated hidden files (#638)
dc0a715
@isha689
fix: handle missing "from" parameter exception (#639)
ae8d593
@sbansla
Update CHANGES.md
7d6933f
@twilio-dx
[Librarian] Regenerated @ 1f092ba9afa4c22854ac65f8a1af7e63b84aae2a
4f67e7c
@twilio-dx
Release 6.0.0-rc.1
ba78db7
fix: corrected pre release version
90fa14a
@Hunga1
fix: corrected AssemblyInfomation release version (#641)
45a621a
@twilio-dx
[Librarian] Regenerated @ 01f08ee7ea770beb526f655c6e616695f7eab4e0
b525da5
@twilio-dx
Release 6.0.0-rc.2
d862a23
fix: correct the Oauth/UserInfo naming
aa96363
@twilio-dx
[Librarian] Regenerated @ 18375def60d612c8e8bd57ea6e45050211ba4c08
51223e3
@twilio-dx
Release 6.0.0-rc.3
19cd0fa
@stern-shawn @JenniferMah
docs: Update README.md for 6.x release (#643)
73110fc 
Co-authored-by: Jennifer Mah <[email protected]>
feat! : Merging 6.0.0-rc branch to main
609aafa
docs: updating doc files
5275ed5
chore: corrected release date in upgrade file
820ba74
childish-sambino
childish-sambino reviewed Nov 14, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/test-and-deploy.yml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sbansla sbansla merged commit 544315f into main Nov 15, 2022
Swimburger pushed a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
@sbansla @JenniferMah @Swimburger
feat!: Merging RC branch to main (twilio#645)
b02353e 
* fix: correct the Oauth/UserInfo naming

* docs: Update README.md for 6.x release (twilio#643)

Co-authored-by: Jennifer Mah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sbansla @childish-sambino @AsabuHere @rohith-prakash @isha689 @twilio-dx @Hunga1 @stern-shawn