fix: handling null 'from' parameter #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbansla
reviewed
Sep 20, 2022
|
Changes looks good to me. |
BrimmingDev
reviewed
Sep 28, 2022
| @@ -17,7 +17,9 @@ public class PhoneNumberConverter : JsonConverter | |||
| /// <param name="serializer">unsued</param> | |||
| public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | |||
| { | |||
| var t = JToken.FromObject(value.ToString()); | |||
| var t = value.ToString() != null | |||
There was a problem hiding this comment.
When this line is called, is object null?
There was a problem hiding this comment.
Object is not null here, but value.ToString() is null, as ToString() method is overriden.
Discussed here previously.
BrimmingDev
approved these changes
Sep 30, 2022
sbansla
approved these changes
Oct 3, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Resolved Issue as part of this PR.
Serialization was failing when 'from' parameter was null, so added a check to handle the null values.
Solution is referenced from here
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.