fix: Patching newer versions of JwtHeader including "cty" #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an overloaded constructor that could take the header directly and sort it out there. However, they it is not available in the old System.IdentityModel.Tokens.Jwt, 5.1.2. This seems like an easy way to deal with it and be able to upgrade beyond 6.17.0.
Proves that the patch works for new and old targets.
|
In 6.20.0 they made it backward-compatible (AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#1861), so the fix is no longer crucial to stay up-to-date. |
childish-sambino
changed the title
Swimburger
pushed a commit
to Swimburger/twilio-csharp
that referenced
this pull request
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Patching newer versions of JwtHeader including "cty".
There is an overloaded constructor that could take the header directly and sort it out there.
However, it is not available in the old System.IdentityModel.Tokens.Jwt, 5.1.2.
This seems like an easy way to deal with it and be able to upgrade beyond 6.17.0.
Checklist