Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the call create 'from' param to be endpoint type for client identifier support #480

Merged
merged 1 commit into from
May 21, 2019
Merged

Update the call create 'from' param to be endpoint type for client identifier support #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/CallOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class CreateCallOptions : IOptions<CallResource>
/// <summary>
/// Twilio number from which to originate the call
/// </summary>
public Types.PhoneNumber From { get; }
public IEndpoint From { get; }
/// <summary>
/// The absolute URL that returns TwiML for this call
/// </summary>
Expand Down Expand Up @@ -132,7 +132,7 @@ public class CreateCallOptions : IOptions<CallResource>
/// </summary>
/// <param name="to"> Phone number, SIP address, or client identifier to call </param>
/// <param name="from"> Twilio number from which to originate the call </param>
public CreateCallOptions(IEndpoint to, Types.PhoneNumber from)
public CreateCallOptions(IEndpoint to, IEndpoint from)
{
To = to;
From = from;
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/CallResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public static async System.Threading.Tasks.Task<CallResource> CreateAsync(Create
/// <param name="client"> Client to make requests to Twilio </param>
/// <returns> A single instance of Call </returns>
public static CallResource Create(IEndpoint to,
Types.PhoneNumber from,
IEndpoint from,
string pathAccountSid = null,
Uri url = null,
string applicationSid = null,
Expand Down Expand Up @@ -217,7 +217,7 @@ public static CallResource Create(IEndpoint to,
/// <param name="client"> Client to make requests to Twilio </param>
/// <returns> Task that resolves to A single instance of Call </returns>
public static async System.Threading.Tasks.Task<CallResource> CreateAsync(IEndpoint to,
Types.PhoneNumber from,
IEndpoint from,
string pathAccountSid = null,
Uri url = null,
string applicationSid = null,
Expand Down