feat(logger): expose errors better & upgrade serverless #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnash
approved these changes
Apr 30, 2020
Contributor
philnash
left a comment
philnash
left a comment
There was a problem hiding this comment.
Just one question, otherwise, looks good to me!
src/commands/deploy.ts
Outdated
|
|
||
| logger.error(messageBody); | ||
| } else if (err.name === 'TwilioApiError') { | ||
| const apiError = err as ClientApiError; |
Contributor
There was a problem hiding this comment.
Why do you need to cast this error as ClientApiError but in the activate, list and logs commands you don't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio