fix(templates): adds tests for getFiles and replaces Array.flat #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkundel
approved these changes
Apr 7, 2020
Contributor
dkundel
left a comment
dkundel
left a comment
There was a problem hiding this comment.
Looks good. Super nit pick: the URLs you use in the test are inconsistent between using twilio-labs and philnash. But otherwise this looks good. Thanks for the quick fix. Can you squash and release a new version?
Contributor
Author
|
Squashed and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123 broke support in Node < 11 due to using
Array#flat🤦♂️This adds tests to ensure the
getFilesfunction works properly and replacesArray#flatwithlodash.flatten.Fixes #124.
Contributing to Twilio