feat(model): add enum variant from/tryfrom conversion#2502
Merged
Conversation
github-actions
bot
added
c-model
vilgotf
commented
Dec 31, 2025
| User(Id<UserMarker>), | ||
| } | ||
|
|
||
| impl CommandOptionValue { |
Member
Author
There was a problem hiding this comment.
SubCommand and SubCommandGroup have the same inner type, so no conversion implementations are provided
| /// | ||
| /// [`member`]: Self::member | ||
| /// [`user`]: Self::user | ||
| pub fn into_author(self) -> Option<User> { |
Member
Author
There was a problem hiding this comment.
Matching owned variant to author()
| @@ -326,37 +469,37 @@ impl<'de> Deserialize<'de> for Component { | |||
| #[derive(Debug, Deserialize)] | |||
| #[serde(field_identifier, rename_all = "snake_case")] | |||
| enum Field { | |||
Member
Author
There was a problem hiding this comment.
Did not bother sorting its usage
| command::{ | ||
| Command, CommandOption, CommandOptionChoice, CommandOptionChoiceValue, | ||
| CommandOptionType, CommandOptionValue, CommandType, | ||
| CommandOptionType, CommandType, |
Member
Author
There was a problem hiding this comment.
Applied the provided From implementations
HTGAzureX1212
approved these changes
Dec 31, 2025
Erk-
approved these changes
Feb 21, 2026
Member
Erk-
left a comment
Erk-
left a comment
There was a problem hiding this comment.
Looks good, I hope its not too painful to rebase on top of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These convenience implementations bring a better developer experience. This PR also features some cleanup with struct field/enum variant sorting