fix: updated application struct#2434
Open
roberts-pumpurs wants to merge 10 commits intotwilight-rs:mainfrom
Open
fix: updated application struct#2434roberts-pumpurs wants to merge 10 commits intotwilight-rs:mainfrom
roberts-pumpurs wants to merge 10 commits intotwilight-rs:mainfrom
Conversation
github-actions
bot
added
c-model
Author
|
discord/discord-api-docs#7586 opened an issue on discord api docs repo too |
github-actions
bot
added
c-cache
Erk-
approved these changes
Jul 21, 2025
Erk-
reviewed
Jul 21, 2025
Member
Erk-
left a comment
Erk-
left a comment
There was a problem hiding this comment.
Change to partial approval, only the latest commit that adds attachment size limits is actually approved.
Member
|
this should probably be split into a separate PR for the documented fields and the workaround for the null urls (that afaik are a discord bug they really should address) |
Erk-
added
the
w-unapproved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My app in production was crashing because the redirect_uris could be null, and thus the JSON deserialisation was failing. During deserialization, the null values will be dropped.
I also added several missing fields to the application struct, hoping it may be helpful to someone, using the Discord API response as a source of truth for the missing fields.