feat(model, cache): Add support for application editing and new application fields #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-http
suneettipirneni
changed the title
laralove143
approved these changes
Oct 14, 2023
Gelbpunkt
requested changes
Nov 24, 2023
Member
Gelbpunkt
left a comment
Gelbpunkt
left a comment
There was a problem hiding this comment.
I'm slightly bothered by the mismatch in naming between GetCurrentUserApplicationInfo and UpdateCurrentUserApplication, either both should have the Info suffix, or neither of them. We should probably remove Info from the former in a followup PR to next (to match the naming in the docs).
Erk-
approved these changes
Dec 29, 2023
Member
Erk-
left a comment
Erk-
left a comment
There was a problem hiding this comment.
Just a small nit, with the changes requested by Gelbpunkt it looks good.
Erk-
approved these changes
Dec 30, 2023
Gelbpunkt
approved these changes
Dec 30, 2023
…eat/application-edit
…eat/application-edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
Additionally, this changes the path for
get_user_applicationto be/application/@meinstead of/oauth2/applications/@mefor consistency. This returns the same data and shouldn't effect any users.