Use bytes for file field on attachment#1886
Closed
ImUrX wants to merge 2 commits intotwilight-rs:mainfrom
Closed
Conversation
Contributor
|
Ideally the struct would take |
Contributor
|
Since this isn't a change we are going to be making soon, I'm going to give this a close. |
itohatweb
added a commit
that referenced
this pull request
Sep 17, 2022
Instead of taking `&'a [u8]` for attachments, which could cause lifetime issues when using functions like `fn create_attachment<'a>() -> Attachment<'a>`, `Cow<'a, u8>` can be used to support both creating attachments from owned and borrowed bytes. This is a followup idea to: #1886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of using the Bytes struct comes from being able to have more flexibility when adding attachments.
Quoting the docs it mentions that
I would honestly just add an
impl Into<Bytes>for thefrom_bytesfunction but it would stop beingconstso it would also require a breaking change.