feat(gateway)!: turn twilight_http optional#1760
Merged
Conversation
github-actions
bot
added
c-gateway
This comment was marked as outdated.
This comment was marked as outdated.
7596ff
previously approved these changes
Jun 1, 2022
vilgotf
force-pushed
the
vilgotf/feat/gateway/optional-http
branch
from
25028bf to
1b378f1
Compare
Member
Author
|
Will be rebased on #1809 |
Contributor
|
Ready for rebase. |
vilgotf
force-pushed
the
vilgotf/feat/gateway/optional-http
branch
from
beaeb70 to
e7cdfff
Compare
Useful when the provided HTTP Client does not require TLS support, for instance when used with a HTTP proxy.
vilgotf
force-pushed
the
vilgotf/feat/gateway/optional-http
branch
from
e7cdfff to
fff53e1
Compare
vilgotf
changed the title
twilight_http featuretwilight_http optional
7596ff
approved these changes
Sep 5, 2022
itohatweb
approved these changes
Sep 16, 2022
7596ff
pushed a commit
that referenced
this pull request
Nov 14, 2022
Allows projects not using Discord's HTTP API to opt out of building `twilight_http`. Can be useful for gateway proxies. HTTP allows the gateway to retrieve Discord's recommended shard count (exposed in the `twilight_gateway::stream::start_recommended` function).
spring4175
pushed a commit
that referenced
this pull request
Dec 28, 2022
Update the TLS section of the book's chapter on the gateway to state there is no requirement on twilight-http as of PR #1760. Also corrects `async-tungstenite` to `tokio-tungstenite` and adds a section about Web PKI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows projects not using Discord's HTTP API to opt out of building
twilight_http. Can be useful for gateway proxies.HTTP allows the gateway to retrieve Discord's recommended shard count (exposed in the
twilight_gateway::stream::start_recommendedfunction).The last commit in this PR (fff53e1) makes the TLS features, combined with
twilight_http, no buildtwilight_httpwith the same TLS variants. This allows projects requiring WSS but not HTTPS; HTTP could in this case be proxied by, for example, twilight-http-proxy.