Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support ts cs lua #73

Merged
merged 8 commits into from
Sep 24, 2022

Conversation

qiaogaojian
Copy link
Contributor

support typescript c# lua

@qiaogaojian
Copy link
Contributor Author

When you merge this request, I'll close another.

@qiaogaojian
Copy link
Contributor Author

I'm tring to add support with more language such as solidity.

@qiaogaojian
Copy link
Contributor Author

When you merge this request, I'll close another.

closed

@twibiral twibiral changed the base branch from master to develop September 23, 2022 15:54
@twibiral
Copy link
Owner

Looks good! I am unsure about your use of runCodeInShell(...) instead of runCode(...). Do the languages you implemented need the shell's support to be executed? Otherwise, it could make sense to skip the shell environment and execute it without shell.

Either way, I think your changes are ready to be merged and released when I am free.

@twibiral
Copy link
Owner

I tested it and it looks like it is necessary to use a shell environment so we can just keep it as it is.

@twibiral twibiral closed this Sep 24, 2022
@twibiral twibiral reopened this Sep 24, 2022
@twibiral twibiral merged commit 4a18a4e into twibiral:develop Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants