quick fix for positionInViewFilterGroup #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the position field handling in query-runner-args.factory.ts to prevent SQL query issues caused by column naming conflicts with 'positionInViewFilterGroup'.
- Added field name check
field.name === 'position'inshouldBackfillPositioncondition to ensure only specific position fields trigger backfilling - Prevents unintended position backfilling for other position-type fields like 'positionInViewFilterGroup' that were causing SQL query failures
- Temporary fix that may need a more comprehensive solution to address underlying column naming conflicts
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
41
to
46
| const shouldBackfillPosition = | ||
| options.objectMetadataItemWithFieldMaps.fields.some( | ||
| (field) => field.type === FieldMetadataType.POSITION, | ||
| (field) => | ||
| field.type === FieldMetadataType.POSITION && | ||
| field.name === 'position', | ||
| ); |
There was a problem hiding this comment.
style: consider making the position field name configurable rather than hardcoding 'position' to support different naming conventions
Fix LGTM as discusses offline. Imho positionInViewFilterGroup should not be named that way or at least I don't see the reasoning behind that name. Let's merge this fix to mitigate the issue and find a better solution for the next release. |
Log |
lucasbordeau
pushed a commit
that referenced
this pull request
Dec 24, 2024
fix 9206 In the future, we should have a look at the column naming "positionInViewFilterGroup" because it breaks the SQL queries in `record-position-query.factory.ts` for viewFilter tablenames
Weiko
pushed a commit
that referenced
this pull request
Dec 26, 2024
fix 9206 In the future, we should have a look at the column naming "positionInViewFilterGroup" because it breaks the SQL queries in `record-position-query.factory.ts` for viewFilter tablenames
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
fix 9206 In the future, we should have a look at the column naming "positionInViewFilterGroup" because it breaks the SQL queries in `record-position-query.factory.ts` for viewFilter tablenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 9206
In the future, we should have a look at the column naming "positionInViewFilterGroup"
because it breaks the SQL queries in
record-position-query.factory.tsfor viewFilter tablenames