Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collapsed navigationDrawerItem width fix #9211

Merged
merged 1 commit into from
Dec 23, 2024
Merged

collapsed navigationDrawerItem width fix #9211

merged 1 commit into from
Dec 23, 2024

Conversation

ehconitin
Copy link
Contributor

Before:

Screenshot 2024-12-23 at 9 25 25 PM

After:

Screenshot 2024-12-23 at 9 25 11 PM

greptile-apps[bot]
greptile-apps bot reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Minor adjustment to the collapsed navigation drawer item width calculation to improve visual alignment and spacing.

  • Modified width calculation in NavigationDrawerItem.tsx from theme.spacing(6) to theme.spacing(5.5) for collapsed state, resulting in better visual alignment

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weiko Weiko merged commit b3c1f62 into twentyhq:main Dec 23, 2024
17 checks passed
@github-actions GitHub Actions
Copy link

Thanks @ehconitin for your contribution!
This marks your 81st PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

samyakpiya pushed a commit to samyakpiya/twenty that referenced this pull request Dec 28, 2024
@ehconitin @samyakpiya
collapsed navigationDrawerItem width fix (twentyhq#9211)
6a4b36d 
Before: 

<img width="81" alt="Screenshot 2024-12-23 at 9 25 25 PM"
src="https://github.com/user-attachments/assets/d4c07ed5-0953-422f-aabf-fa2ca10ba7e5"
/>

After: 

<img width="76" alt="Screenshot 2024-12-23 at 9 25 11 PM"
src="https://github.com/user-attachments/assets/1ea6d64e-8c1f-4d0c-9b34-f8dceae9538d"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehconitin @Weiko