Fixed dragging with empty orphan favorites #9205
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves drag-and-drop functionality for favorites by implementing dynamic container sizing and removing fixed margins that were causing positioning issues.
- Removed hardcoded 15px margin in
/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsxthat was causing drop area overlap - Added dynamic height (24px/1px) for empty orphan favorites container in
/packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsxto create proper droppable zones - Replaced theme-based spacing with state-based container sizing for better drag-and-drop accuracy
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| // TODO: (Drag Drop Bug) Adding bottom margin to ensure drag-to-last-position works. Need to find better solution that doesn't affect spacing. | ||
| // Issue: Without margin, dragging to last position triggers next folder drop area |
There was a problem hiding this comment.
style: The TODO comment is now outdated since the margin-based workaround has been removed. Either update or remove this comment to reflect the new solution.
| @@ -67,7 +66,7 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => { | |||
| /> | |||
| )) | |||
| ) : ( | |||
| <StyledEmptyContainer /> | |||
| <StyledEmptyContainer style={{ height: isDragging ? '24px' : '1px' }} /> | |||
There was a problem hiding this comment.
style: Consider using theme.spacing(3) instead of hardcoded '24px' to maintain consistency with the design system
| @@ -67,7 +66,7 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => { | |||
| /> | |||
| )) | |||
| ) : ( | |||
| <StyledEmptyContainer /> | |||
| <StyledEmptyContainer style={{ height: isDragging ? '24px' : '1px' }} /> | |||
There was a problem hiding this comment.
style: 1px height might cause layout shift when transitioning to drag state - consider using 0 instead
Created a resizable container tied to dragging state to create suitable droppable zone when there's no orphan favorites. Co-authored-by: Weiko <[email protected]>
Created a resizable container tied to dragging state to create suitable droppable zone when there's no orphan favorites.