Fix position calculations -- favorites #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes position calculation issues in the favorites system by modifying how positions are handled during drag-and-drop operations and list reordering.
- Changed position calculation in
calculateNewPosition.tsto subtract 1 instead of dividing by 2 when moving items to start - Updated
useHandleFavoriteDragAndDrop.tsto start positions at 1 for empty lists and exclude dragged items from position calculations - Modified mock data in
useFavorites.tsto use consistent position values (1 instead of 0) for folder moves - Fixed edge case in drag-and-drop when moving items between folders by using proper position references
- Added proper position handling for empty destination folders during drag operations
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
12
to
14
| if (destinationIndex === 0) { | ||
| return items[0].position / 2; | ||
| return items[0].position - 1; | ||
| } |
There was a problem hiding this comment.
logic: Subtracting 1 from position could eventually cause integer underflow with repeated moves to start. Consider using a larger decrement (e.g. -100) or position normalization.
packages/twenty-front/src/modules/favorites/utils/calculateNewPosition.ts
Show resolved
Hide resolved
|
Thanks @ehconitin for your contribution! |
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.