Fix show page navigation bugs #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the show page navigation system by improving key prop stability in action menu buttons and refining pagination logic for better edge case handling.
- Added unique
entry.keyprop for Button/IconButton components in/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsxreplacing array indices - Improved pagination logic in
/packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.tswith explicit first/last record checks and cache availability validation - Fixed total count calculation by including current record in
/packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+133
to
+146
| if (isFirstRecord) { | ||
| if (cacheIsAvailableForNavigation) { | ||
| const lastRecordIdFromCache = | ||
| recordIdsInCache[recordIdsInCache.length - 1]; | ||
|
|
||
| navigate( | ||
| buildShowPageURL( | ||
| objectNameSingular, | ||
| lastRecordIdFromCache, | ||
| viewIdQueryParam, | ||
| ), | ||
| ); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
logic: potential race condition if cache becomes unavailable between check and navigation
Weiko
approved these changes
Dec 23, 2024
| const navigateToNextRecord = () => { | ||
| if (isDefined(recordAfter)) { | ||
| if (isLastRecord) { | ||
| if (cacheIsAvailableForNavigation) { |
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Fixes total count bug that was -1 the total count Fixes a bug when trying to go from first to last or the other way around Fixes a React array key bug Follow-up issue (non critical) : twentyhq#9197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes total count bug that was -1 the total count
Fixes a bug when trying to go from first to last or the other way around
Fixes a React array key bug
Follow-up issue (non critical) : #9197