fix(auth): adjust button variant based on sign-in-up step #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the button variant to dynamically switch between 'secondary' and 'primary' based on the current step in the sign-in-up flow. Ensures the UI reflects the correct state, improving user experience and consistency.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the MainButton component's visual state in the authentication flow to provide better user feedback by dynamically adjusting the button variant based on the current sign-in/sign-up step.
- Updates
SignInUpGlobalScopeForm.tsxto set button variant to 'secondary' for initial step and 'primary' for password step - Button text changes from 'Continue' to 'Sign Up' when transitioning to password step
- Maintains visual consistency with existing Google/Microsoft auth buttons in the same form
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
126
to
127
| signInUpStep === SignInUpStep.Password ? 'Sign Up' : 'Continue' | ||
| } |
There was a problem hiding this comment.
logic: Button shows 'Sign Up' in Password step but SignInUpMode could be SignIn - this may confuse users
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the button variant to dynamically switch between 'secondary' and 'primary' based on the current step in the sign-in-up flow. Ensures the UI reflects the correct state, improving user experience and consistency.