Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove favorite folder related feature flags #9178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ehconitin
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 20, 2024

TODOs/FIXMEs:

  • //todo: remove this logic once feature flag gating is removed: packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavoritesFolders.tsx
  • // TODO: Remove this filter once we merge PrefetchFavortiteFoldersRunQueriesEffect with this component: packages/twenty-front/src/modules/prefetch/components/PrefetchRunQueriesEffect.tsx

Generated by 🚫 dangerJS against 6b64732

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes feature flag controls for favorite folders functionality across the frontend and backend, making it a permanent feature rather than conditionally enabled.

  • Removed IS_FAVORITE_FOLDER_ENABLED and IS_FAVORITE_FOLDER_ENTITY_ENABLED from packages/twenty-front/src/modules/workspace/types/FeatureFlagKey.ts and corresponding server enums
  • Merged PrefetchFavoriteFoldersRunQueriesEffect into packages/twenty-front/src/modules/prefetch/components/PrefetchRunQueriesEffect.tsx to consolidate prefetching logic
  • Removed feature flag gates from workspace entities in packages/twenty-server/src/modules/favorite-folder/standard-objects/favorite-folder.workspace-entity.ts and related files
  • Simplified loading states in packages/twenty-front/src/modules/prefetch/hooks/useIsPrefetchLoading.ts to always include favorite folders prefetching
  • Removed feature flag seeds from packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts since the functionality is now permanent

16 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant