Workspace logo is not visible #9174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillim
added
scope: front
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes workspace logo visibility in the navigation drawer by removing conditional rendering logic that previously prevented the header from displaying when no logo was present.
- Modified
packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsxto always renderNavigationDrawerHeaderregardless of logo presence - Added fallback empty string for logo prop to prevent undefined rendering issues
- Improved code formatting with proper JSX parentheses structure
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| ) : ( | ||
| <NavigationDrawerHeader | ||
| name={title} | ||
| logo={logo || ''} |
There was a problem hiding this comment.
style: Passing empty string as fallback could cause unnecessary re-renders. Consider using null or undefined instead.
charlesBochet
approved these changes
Dec 20, 2024
|
Thanks @guillim for your contribution! |
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Fixing "Workspace logo is not visible in the navbar" report issue from @Weiko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing "Workspace logo is not visible in the navbar" report issue from @Weiko