Don't register delete multiple records action when deleted filter is active #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the delete action functionality to prevent users from attempting to delete records that have already been marked as deleted by checking the filter state.
- Added check for
deletedAtfield metadata inuseDeleteMultipleRecordsAction.tsxto prevent delete action registration when deleted filter is active - Incorporated filter state check into
canDeletecondition to improve user experience by avoiding invalid delete attempts - Enhanced action menu entry management by considering record deletion status before registration
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...action-menu/actions/record-actions/multiple-records/hooks/useDeleteMultipleRecordsAction.tsx
Outdated
Show resolved
Hide resolved
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
…active (twentyhq#9170) Don't register delete multiple records action when deleted filter is active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't register delete multiple records action when deleted filter is active