-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fix -- datamodel multiselect edit form dropdowns #9168
Merged
lucasbordeau
merged 1 commit into
twentyhq:main
from
ehconitin:dropdown-refactor-followup
Dec 20, 2024
Merged
minor fix -- datamodel multiselect edit form dropdowns #9168
lucasbordeau
merged 1 commit into
twentyhq:main
from
ehconitin:dropdown-refactor-followup
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixed potential dropdown conflicts in data model field settings by ensuring unique dropdown IDs for each option row.
- Modified dropdown IDs in
SettingsDataModelFieldSelectFormOptionRow.tsx
to includeoption.id
for uniqueness across multiple rows - Affects both color selection and actions dropdowns in the field settings form
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
lucasbordeau
approved these changes
Dec 20, 2024
Log
|
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
made sure dropdown gets unique ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made sure dropdown gets unique ids.