Phone country fix #9167
Merged
Phone country fix #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
reviewed
Dec 20, 2024
...ges/twenty-server/src/database/commands/upgrade-version/0-40/0-40-upgrade-version.command.ts
Outdated
Show resolved
Hide resolved
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the phone calling code migration process by improving command execution order and logging behavior in the database upgrade commands.
- Reordered commands in
/packages/twenty-server/src/database/commands/upgrade-version/0-40/0-40-upgrade-version.command.tsto execute phone-related operations before record position backfilling - Added verbose logging control in
/packages/twenty-server/src/database/commands/logger.tswith newisCommandLoggertype guard - Improved error handling in phone migration commands by replacing console.log with proper logger usage
- Added validation check for
primaryPhoneCallingCodebefore updating field metadata to prevent duplicate updates
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/database/commands/upgrade-version/0-40/0-40-phone-calling-code-create-column.command.ts
Outdated
Show resolved
Hide resolved
.../src/database/commands/upgrade-version/0-40/0-40-phone-calling-code-create-column.command.ts
Show resolved
Hide resolved
...r/src/database/commands/upgrade-version/0-40/0-40-phone-calling-code-migrate-data.command.ts
Show resolved
Hide resolved
Weiko
approved these changes
Dec 20, 2024
|
Thanks @guillim for your contribution! |
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.