9018 fix batch delete follow ups #9166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosiraphael
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses batch deletion performance and UI feedback issues by implementing several key changes to the record deletion system.
- Replaced hardcoded action keys with standardized enums (
MultipleRecordsActionKeys,SingleRecordActionKeys) for better type safety and maintainability - Added load-more locking during deletion operations in
RecordIndexActionMenuto prevent UI inconsistencies - Moved favorite deletion handling to a new
deleteCascadeQueuefor better cascade operation management - Fixed incorrect record selection count during batch deletions by improving filter handling in
useDeleteMultipleRecordsAction - Optimized batch deletion performance by removing individual optimistic updates in favor of batch updates in
useDeleteManyRecords
21 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
...on-menu/actions/record-actions/single-record/constants/DefaultSingleRecordActionsConfigV2.ts
Show resolved
Hide resolved
...tions/record-actions/single-record/workflow-actions/types/WorkflowSingleRecordActionsKeys.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useDeleteManyRecords.ts
Show resolved
Hide resolved
| @@ -18,5 +18,5 @@ | |||
| "src/**/*.d.ts", | |||
| "src/**/*.ts", | |||
| "src/**/*.tsx" | |||
| ] | |||
| , "src/modules/action-menu/actions/record-actions/single-record/workflow-version-actions/types/WorkflowVersionSingleRecordActionsKeys.ts" ] | |||
charlesBochet
approved these changes
Dec 20, 2024
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 20, 2024
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups on #9018