Fix activity editor #9165
Fix activity editor #9165
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the activity editor by separating title and body management concerns, focusing on a more specialized rich text editing implementation for activities.
- Renamed
RichTextEditortoActivityRichTextEditorin/packages/twenty-front/src/modules/activities/components/ActivityRichTextEditor.tsxand removed title-related functionality - Added new hook
useReplaceActivityBlockEditorContentwith potential JSON parsing vulnerability and incorrectreplaceBlocksimplementation - Added
ActivityRichTextEditorChangeOnActivityIdEffectcomponent to handle content updates, though it may have race condition issues - Removed
activityBodyFamilyStateandactivityTitleHasBeenSetFamilyStatefor simpler state management - Eliminated drag bug workaround that used debounced state setter
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| const content = isNonEmptyString(activityInStore?.body) | ||
| ? JSON.parse(activityInStore?.body) | ||
| : [{ type: 'paragraph', content: '' }]; |
There was a problem hiding this comment.
style: JSON.parse could throw for malformed JSON. Wrap in try/catch and fallback to empty paragraph
| replaceBlockEditorContent(activityId); | ||
| setCurrentActivityId(activityId); | ||
| } |
There was a problem hiding this comment.
logic: Potential race condition between replaceBlockEditorContent and setCurrentActivityId. Consider using an async/await pattern or ensuring replaceBlockEditorContent completes before updating state.
| const { replaceBlockEditorContent } = | ||
| useReplaceActivityBlockEditorContent(editor); | ||
|
|
||
| const [currentActivityId, setCurrentActivityId] = useState(activityId); |
There was a problem hiding this comment.
style: Initial state could be unnecessary since the effect already handles the first render. Consider removing the state and tracking changes differently.
No description provided.