Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon alignment in NavigationDrawerItems #9164

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Icon alignment in NavigationDrawerItems #9164

merged 2 commits into from
Dec 20, 2024

Conversation

ehconitin
Copy link
Contributor

@ehconitin ehconitin commented Dec 20, 2024 •
edited
Loading

Icons are not aligned to the labels
before:
Screenshot 2024-12-20 at 4 09 01 PM

after:

Screenshot 2024-12-20 at 4 08 36 PM

greptile-apps[bot]
greptile-apps bot reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Improved icon alignment in NavigationDrawerItem component by modifying the StyledIcon styling to ensure proper centering of icons within their containers.

  • Added display: flex, align-items: center, and justify-content: center to StyledIcon in /packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx for consistent icon positioning

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

martmull
martmull approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@charlesBochet charlesBochet merged commit 2e216e7 into twentyhq:main Dec 20, 2024
19 of 20 checks passed
@github-actions GitHub Actions
Copy link

Thanks @ehconitin for your contribution!
This marks your 77th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

mdrazak2001 pushed a commit to mdrazak2001/twenty that referenced this pull request Dec 20, 2024
@ehconitin @mdrazak2001
Icon alignment in NavigationDrawerItems (twentyhq#9164)
f1e38db 
Icons are not aligned to the labels
before:
<img width="387" alt="Screenshot 2024-12-20 at 4 09 01 PM"
src="https://github.com/user-attachments/assets/c115abcd-9779-4597-b40e-6ceceeaa13b9"
/>

after: 

<img width="387" alt="Screenshot 2024-12-20 at 4 08 36 PM"
src="https://github.com/user-attachments/assets/a0535030-a810-4023-b677-8380b833f712"
/>
samyakpiya pushed a commit to samyakpiya/twenty that referenced this pull request Dec 28, 2024
@ehconitin @samyakpiya
Icon alignment in NavigationDrawerItems (twentyhq#9164)
f821582 
Icons are not aligned to the labels
before:
<img width="387" alt="Screenshot 2024-12-20 at 4 09 01 PM"
src="https://github.com/user-attachments/assets/c115abcd-9779-4597-b40e-6ceceeaa13b9"
/>

after: 

<img width="387" alt="Screenshot 2024-12-20 at 4 08 36 PM"
src="https://github.com/user-attachments/assets/a0535030-a810-4023-b677-8380b833f712"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@martmull martmull martmull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehconitin @martmull @charlesBochet