Fix sync metadata default value not being synced #9163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the metadata syncing by removing 'defaultValue' from the ignored properties list, allowing it to be properly synced while maintaining type-specific override protections.
- Removed 'defaultValue' from
commonFieldPropertiesToIgnorein/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts defaultValuesyncing is now controlled byshouldNotOverrideDefaultValuefunction for specific field types (BOOLEAN, SELECT, etc.)- Property is properly stringified during comparison via
fieldPropertiesToStringifyarray
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Dec 20, 2024
charlesBochet
deleted the
c--fix-sync-metadata-default-value-not-being-synced
branch
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 20, 2024
## Context We used to not sync defaultValue and recently introduced a change in https://github.com/twentyhq/twenty/blob/3340f01c312de9d9ca6a4f19f45437d9d850fff0/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts with shouldNotOverrideDefaultValue to sync it for specific field metadata type that can't be overwritten by the user. This means we should have removed 'defaultValue' from commonFieldPropertiesToIgnore list since it was handled differently. This PR fixes that Before <img width="792" alt="Screenshot 2024-12-20 at 11 04 09" src="https://github.com/user-attachments/assets/1771c5a3-2162-4013-8a08-c54d2619fda3" /> After <img width="798" alt="Screenshot 2024-12-20 at 11 04 55" src="https://github.com/user-attachments/assets/33e09f16-c615-4a43-950d-d2df955fb196" />
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
## Context We used to not sync defaultValue and recently introduced a change in https://github.com/twentyhq/twenty/blob/3340f01c312de9d9ca6a4f19f45437d9d850fff0/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts with shouldNotOverrideDefaultValue to sync it for specific field metadata type that can't be overwritten by the user. This means we should have removed 'defaultValue' from commonFieldPropertiesToIgnore list since it was handled differently. This PR fixes that Before <img width="792" alt="Screenshot 2024-12-20 at 11 04 09" src="https://github.com/user-attachments/assets/1771c5a3-2162-4013-8a08-c54d2619fda3" /> After <img width="798" alt="Screenshot 2024-12-20 at 11 04 55" src="https://github.com/user-attachments/assets/33e09f16-c615-4a43-950d-d2df955fb196" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We used to not sync defaultValue and recently introduced a change in https://github.com/twentyhq/twenty/blob/3340f01c312de9d9ca6a4f19f45437d9d850fff0/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts
with shouldNotOverrideDefaultValue to sync it for specific field metadata type that can't be overwritten by the user.
This means we should have removed 'defaultValue' from commonFieldPropertiesToIgnore list since it was handled differently.
This PR fixes that
Before
After
