Scrollable fixed dropdowns container minor refactor #9159
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR standardizes dropdown menu behavior and structure across multiple components in the Twenty frontend.
- Changed
withoutScrollWrapperprop toscrollable={false}inDropdownMenuItemsContainercomponents for more intuitive API - Removed unnecessary
DropdownMenuwrapper components while preserving functionality in summary cards and select forms - Added
DropdownMenuSeparatorcomponents between content sections for better visual hierarchy - Fixed save/action buttons to be non-scrollable in view pickers and relation selectors
- Simplified dropdown menu structure by removing redundant fragment wrappers and organizing imports
20 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -87,7 +87,7 @@ export const ObjectOptionsDropdownHiddenFieldsContent = () => { | |||
| closeDropdown(); | |||
| }} | |||
| > | |||
| <DropdownMenuItemsContainer withoutScrollWrapper> | |||
| <DropdownMenuItemsContainer scrollable={false}> | |||
There was a problem hiding this comment.
style: scrollable={false} is only needed for single menu items that don't require scrolling. Consider removing this prop since it's redundant here - the container will never need to scroll with just one menu item.
| @@ -144,7 +144,7 @@ export const MultiRecordSelect = ({ | |||
| {dropdownPlacement?.includes('end') && ( | |||
There was a problem hiding this comment.
style: duplicate code structure between end and start placement branches. Consider extracting into a shared function to reduce code duplication
|
Thanks @ehconitin for your contribution! |
Co-authored-by: Lucas Bordeau <[email protected]>
Co-authored-by: Lucas Bordeau <[email protected]>
No description provided.