Fix modals being unregistered inside command menu #9155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a new shouldCloseCommandMenuOnClick property across command menu components to control menu closing behavior after item clicks, fixing issues with premature modal unregistration.
- Added
shouldCloseCommandMenuOnClicktoCommandtype intypes/Command.tsand implemented inCommandMenuItem.tsx - Set
shouldCloseCommandMenuOnClick: truefor all navigation commands inCommandMenuNavigateCommands.ts - Added
ActionMenuContextprovider withonActionExecutedCallbackinDefaultLayout.tsxto handle menu closing on action execution - Updated
useCommandMenuhook to conditionally close menu based onshouldCloseCommandMenuOnClickparameter - Added test coverage for new
shouldCloseCommandMenuOnClickbehavior inuseCommandMenu.test.tsx
7 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/command-menu/constants/CommandMenuNavigateCommands.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/hooks/useCommandMenu.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/hooks/__tests__/useCommandMenu.test.tsx
Show resolved
Hide resolved
martmull
reviewed
Dec 19, 2024
packages/twenty-front/src/modules/command-menu/hooks/useCommandMenu.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/hooks/useCommandMenu.ts
Outdated
Show resolved
Hide resolved
martmull
approved these changes
Dec 19, 2024
charlesBochet
approved these changes
Dec 20, 2024
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 20, 2024
Fix modals being unregistered inside command menu
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Fix modals being unregistered inside command menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modals being unregistered inside command menu