Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes total person count #9154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes total person count #9154

wants to merge 1 commit into from
+2 −2

Conversation

mdrazak2001
Copy link
Contributor

fixes #9152

greptile-apps[bot]
greptile-apps bot reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed incorrect person count display in Person View page by adjusting the total count calculation in useRecordShowPagePagination.ts to include the currently viewed record.

  • Modified packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts to add +1 to totalCount to include current record
  • Ensures consistency between dashboard (7 persons) and Person View page count (now also 7)

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Total Persons count in Person View
1 participant
@mdrazak2001