Fix discard draft optimistic rendering #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements proper cache management when deleting workflow versions by updating the Apollo cache to remove deleted versions from their parent workflow's version list.
- Added cache cleanup in
useDeleteOneWorkflowVersion.tsusingapolloClient.cache.modifyto filter out deleted versions - Added null checks for
cachedWorkflowVersionandcachedWorkflowbefore cache modification - Uses
apolloClient.cache.identifyto correctly reference the workflow record in cache - Maintains data consistency by removing the version from both the direct record and its parent workflow's versions array
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| }); | ||
| const getWorkflowFromCache = useGetRecordFromCache({ | ||
| objectNameSingular: CoreObjectNameSingular.Workflow, | ||
| }); | ||
|
|
||
| const deleteOneWorkflowVersion = async ({ | ||
| workflowVersionId, | ||
| }: { | ||
| workflowVersionId: string; | ||
| }) => { | ||
| await deleteOneRecord(workflowVersionId); |
There was a problem hiding this comment.
style: deleteOneRecord could fail - wrap in try/catch to handle errors gracefully
Comment on lines
+41
to
+50
| apolloClient.cache.modify({ | ||
| id: apolloClient.cache.identify(cachedWorkflow), | ||
| fields: { | ||
| versions: () => { | ||
| return cachedWorkflow.versions.filter( | ||
| (version) => version.id !== workflowVersionId, | ||
| ); | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
logic: cache modification happens after deletion - if deletion fails, cache will be inconsistent
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 20, 2024
Remove draft workflow version from cached workflow
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Remove draft workflow version from cached workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove draft workflow version from cached workflow