Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github CI workflow fix #9137

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Dec 18, 2024

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the CI demo check workflow with improvements to its triggering mechanisms and test command reliability.

  • Added workflow_dispatch trigger in .github/workflows/ci-demo-check.yml to enable manual workflow runs
  • Fixed test command by adding quotes around @demo-only grep pattern to prevent pattern matching issues
  • Renamed workflow from "CI demo check" to "CI Demo check" for consistency

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 811002d into twentyhq:main Dec 19, 2024
20 checks passed
Copy link

Thanks @BOHEUS for your contribution!
This marks your 25th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

mdrazak2001 pushed a commit to mdrazak2001/twenty that referenced this pull request Dec 20, 2024
@BOHEUS BOHEUS deleted the github_ci_demo_check_fix branch December 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants