Add UUID form field input #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added UUID form field input functionality with variable support and comprehensive testing coverage.
- Added
FormUuidFieldInputcomponent in/packages/twenty-front/src/modules/object-record/record-field/form-types/components/FormUuidFieldInput.tsxwith variable picker integration - Added UUID field handling in
/packages/twenty-front/src/modules/object-record/record-field/components/FormFieldInput.tsxwith type guard support - Added Storybook tests in
FormUuidFieldInput.stories.tsxcovering UUID input variations and variable replacement - No UUID format validation implemented, allowing invalid UUIDs to be persisted
- Test coverage uses non-UUID values in some cases which may not reflect real usage patterns
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| <FormUuidFieldInput | ||
| label={field.label} | ||
| defaultValue={defaultValue as string | null | undefined} | ||
| onPersist={onPersist} |
There was a problem hiding this comment.
logic: onPersist should be wrapped to ensure it returns the correct type - (value: string | null) => onPersist(value as JsonValue)
| const input = await canvas.findByPlaceholderText('Enter UUID'); | ||
| expect(input).toBeVisible(); | ||
|
|
||
| const uuid = 'test'; |
There was a problem hiding this comment.
logic: Using 'test' as UUID value doesn't match real UUID format. Should use valid UUID to properly test clearing functionality.
Comment on lines
+182
to
+195
| const [, , variableTag] = await Promise.all([ | ||
| userEvent.click(addVariableButton), | ||
|
|
||
| waitForElementToBeRemoved(input), | ||
| waitFor(() => { | ||
| const variableTag = canvas.getByText('test'); | ||
| expect(variableTag).toBeVisible(); | ||
|
|
||
| return variableTag; | ||
| }), | ||
| waitFor(() => { | ||
| expect(args.onPersist).toHaveBeenCalledWith('{{test}}'); | ||
| }), | ||
| ]); |
There was a problem hiding this comment.
logic: Promise.all array has 4 promises but only 3 values are destructured, which could cause confusion
| defaultValue: string | null | undefined; | ||
| placeholder: string; | ||
| onPersist: (value: string | null) => void; | ||
| readonly?: boolean; |
There was a problem hiding this comment.
logic: readonly prop is defined but never used in the component
Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.