feat(auth): enhance workspace handling and error feedback #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for setting a user's default workspace during sign-in if a target workspace subdomain exists. Enhance error feedback by displaying authentication error messages using a Snackbar in the front-end and improving redirect logic for workspace-specific errors.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced workspace-specific authentication handling and error feedback by adding default workspace selection during sign-in and improved error message display.
- Added
saveDefaultWorkspaceIfUserHasAccessOrThrowinsign-in-up.service.tsto set user's default workspace when target subdomain is specified - Enhanced
google-auth.controller.tsto find and use active Google-auth-enabled workspaces when target is default subdomain - Added SnackBar error message display in
VerifyEffect.tsxfor authentication failures - Improved workspace validation with proper error handling for workspace existence and access rights
- Updated redirect logic to use target workspace subdomain for error redirects instead of default subdomain
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Dec 18, 2024
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting a user's default workspace during sign-in if a target workspace subdomain exists. Enhance error feedback by displaying authentication error messages using a Snackbar in the front-end and improving redirect logic for workspace-specific errors.