Remove buggy dependencies #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
8239-on-the-kanban-view-when-i-export-my-data-for-the-first-time-download-is-triggered-twice
branch
2 times, most recently
from
3801754 to
a31a720
Compare
martmull
force-pushed
the
8239-on-the-kanban-view-when-i-export-my-data-for-the-first-time-download-is-triggered-twice
branch
from
a31a720 to
12ba448
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors record fetching logic to fix a double download issue by consolidating functionality into the useLazyFetchAllRecords hook and improving state management.
- Added progress tracking and download state management in
/packages/twenty-front/src/modules/object-record/hooks/useLazyFetchAllRecords.ts - Replaced
useFetchAllRecordIdswithuseLazyFetchAllRecordsin/packages/twenty-front/src/modules/action-menu/actions/record-actions/multiple-records/hooks/useDeleteMultipleRecordsAction.tsx - Added configurable delay between requests and maximum request limit to prevent server overload
- Added new test coverage in
/packages/twenty-front/src/modules/object-record/hooks/__tests__/useLazyFetchAllRecords.test.tsx
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
...action-menu/actions/record-actions/multiple-records/hooks/useDeleteMultipleRecordsAction.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/__tests__/useLazyFetchAllRecords.test.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useLazyFetchAllRecords.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/__tests__/useLazyFetchAllRecords.test.tsx
Show resolved
Hide resolved
charlesBochet
approved these changes
Dec 18, 2024
martmull
deleted the
8239-on-the-kanban-view-when-i-export-my-data-for-the-first-time-download-is-triggered-twice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes double download