Add fields to update in update record action #9108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomtrp
commented
Dec 17, 2024
thomtrp
commented
- update backend action so it handles composite fields
- add fields to update multiselect
- generate form based on that field
- add icons
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds selective field updates to the workflow update record action, allowing users to specify which fields should be updated when modifying records.
Key changes:
- Added
fieldsToUpdatearray toWorkflowUpdateRecordActionSettingsto control which fields are updated - Added field selection UI with
FormMultiSelectFieldInputinWorkflowEditActionFormUpdateRecordcomponent - Enhanced
MultiSelectInputandMultiSelectDisplaycomponents with icon support for better field visualization - Modified backend
UpdateRecordWorkflowActionto filter updates based on selected fields - Added support for composite fields in the workflow update record action
9 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/ui/field/display/components/MultiSelectDisplay.tsx
Show resolved
Hide resolved
...rkflow-executor/workflow-actions/record-crud/types/workflow-record-crud-action-input.type.ts
Show resolved
Hide resolved
...les/workflow/workflow-executor/workflow-actions/record-crud/update-record.workflow-action.ts
Show resolved
Hide resolved
...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormUpdateRecord.tsx
Show resolved
Hide resolved
Devessier
reviewed
Dec 18, 2024
Comment on lines
+43
to
+55
| const AVAILABLE_FIELD_METADATA_TYPES = [ | ||
| FieldMetadataType.Text, | ||
| FieldMetadataType.Number, | ||
| FieldMetadataType.Date, | ||
| FieldMetadataType.Boolean, | ||
| FieldMetadataType.Select, | ||
| FieldMetadataType.MultiSelect, | ||
| FieldMetadataType.Emails, | ||
| FieldMetadataType.Links, | ||
| FieldMetadataType.FullName, | ||
| FieldMetadataType.Address, | ||
| ]; | ||
|
|
There was a problem hiding this comment.
What is the reason behind this static list of field types?
There was a problem hiding this comment.
@Devessier I do not want the user to select a field a do not see the form to be updated. That would look weird. Some fields such as Rating may not be implemented before we get our first users in Beta. I prefer adding this list and remove it once we have all fields
thomtrp
force-pushed
the
tt-add-fields-to-update-in-update-action
branch
from
1bda1af to
57970fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.