8978 add navigation inside the command menu for showpage #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds record navigation capabilities to the command menu for show pages, with significant architectural changes to support contextual actions.
- Added new navigation hooks
useNavigateToNextRecordSingleRecordActionanduseNavigateToPreviousRecordSingleRecordActionwith looping behavior when reaching first/last records - Introduced
ContextStoreViewTypeenum andcontextStoreCurrentViewTypeComponentStateto control action visibility based on current view (Table/Kanban/ShowPage) - Added
shortLabelandavailableOnproperties toActionMenuEntrytype for better control over action display and context-specific visibility - Removed pagination buttons from PageHeader, moving navigation entirely to command menu with new chevron icons
- Modified action configs (V1, V2, Workflow) to support view-specific actions through
ActionAvailableOnenum
22 file(s) reviewed, 22 comment(s)
Edit PR Review Bot Settings | Greptile
.../record-actions/single-record/components/ShowPageSingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
.../record-actions/single-record/components/ShowPageSingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
.../record-actions/single-record/components/ShowPageSingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
.../actions/record-actions/single-record/components/SingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
...on-menu/actions/record-actions/single-record/constants/DefaultSingleRecordActionsConfigV2.ts
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/record-index/components/RecordIndexContainer.tsx
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts
Outdated
Show resolved
Hide resolved
thomtrp
approved these changes
Dec 17, 2024
bosiraphael
deleted the
8978-add-navigation-inside-the-command-menu-for-showpage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8978
shortLabel,availableOnuseRecordShowPagePaginationto loop on records when we are on first record and we hit previous or when we are on last record and we hit nextcontextStoreCurrentViewTypeComponentState