Fix re render view groups #9098
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes record group visibility handling and reduces unnecessary re-renders in the view groups functionality.
- Changed default value in
recordIndexRecordGroupHideComponentState.tsto hide empty record groups by default - Simplified visibility state management in
useRecordGroupVisibility.tsby removing complex state handling - Replaced dynamic UUID with static ID
20202020-c05f-46c9-ae1e-2b3c5c702049for 'No Value' column inmapViewGroupsToRecordGroupDefinitions.ts - Switched from
viewSortsto directrecordIndexSortsStateusage in drag-and-drop context - Fixed redundant visibility checks in
visibleRecordGroupIdsComponentSelector.ts
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -65,7 +64,7 @@ export const mapViewGroupsToRecordGroupDefinitions = ({ | |||
| ); | |||
|
|
|||
| const noValueColumn = { | |||
| id: viewGroup?.id ?? v4(), | |||
| id: viewGroup?.id ?? '20202020-c05f-46c9-ae1e-2b3c5c702049', | |||
There was a problem hiding this comment.
logic: Using a hardcoded UUID could cause collisions if multiple instances of this component exist simultaneously. Consider using a more unique identifier pattern or documenting this limitation.
| @@ -65,7 +64,7 @@ export const mapViewGroupsToRecordGroupDefinitions = ({ | |||
| ); | |||
|
|
|||
| const noValueColumn = { | |||
| id: viewGroup?.id ?? v4(), | |||
| id: viewGroup?.id ?? '20202020-c05f-46c9-ae1e-2b3c5c702049', | |||
There was a problem hiding this comment.
This is going to cause conflict issues on the backend side if a view group with this id already exist
There was a problem hiding this comment.
Good point, as we introduce /backfill noValue groups in backend this will only be use for smooth migrations during 0.40 release. I think it's fine :)
packages/twenty-front/src/modules/object-record/record-group/hooks/useSetRecordGroup.ts
Show resolved
Hide resolved
No description provided.