Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix advanced mode settings navigation animations #9096

Merged

Conversation

ehconitin
Copy link
Contributor

Before:

2024-12-17.14-02-28.mov

After:

2024-12-17.14-02-07.mov

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the animation behavior for advanced mode settings in the navigation drawer by splitting and refining the animation controls.

  • Separated animation controls into distinct securityRef and developersRef for independent section transitions
  • Added AnimatePresence wrapper around security section to handle exit animations smoothly
  • Implemented dedicated animation variants for security and developers sections
  • Improved visual feedback when toggling advanced mode features in settings navigation

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@FelixMalfait FelixMalfait merged commit 0692bba into twentyhq:main Dec 17, 2024
20 checks passed
Copy link

Thanks @ehconitin for your contribution!
This marks your 69th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants