Refacto scroll + Aggregate queries for view groups #9089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors scroll management to prevent table-wide re-renders when opening dropdowns, while also adding aggregate query functionality for view groups.
- Replaces global scroll states with component-scoped states using
ScrollWrapperComponentInstanceContextand newscrollWrapper*ComponentStateimplementations - Adds
useRecordGroupFilterhook to handle record filtering in aggregate queries for view groups - Removes
aggregateOperationfrom column definitions in favor of a new implementation for aggregate queries - Adds unique
componentInstanceIdprops to allScrollWrapperinstances for isolated scroll state management - Introduces
useToggleScrollWrapperhook for granular control over scroll behavior when dropdowns are opened
47 file(s) reviewed, 21 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupFilter.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupFilter.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/scroll/hooks/useToggleScrollWrapper.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/scroll/hooks/useToggleScrollWrapper.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/scroll/states/scrollPositionState.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/scroll/states/overlayScrollbarsState.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/utils/mapColumnDefinitionToViewField.ts
Show resolved
Hide resolved
charlesBochet
pushed a commit
that referenced
this pull request
Dec 18, 2024
- Fixed icon shrinking on tabs. The introduction of EllipsisDisplay takes 100% of the width, thus shrinking the icons. - Removed scroll wrapper tablist. This was removed in #9016 but reintroduced in #9089. This reintroduction made the dark border below the active tab disappear. - Used Avatar for icon and logo rendering following the changes made in #9093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/twentyhq/private-issues/issues/217.
Refactoring scroll not to cause table-wide re-render when opening a dropdown (triggering a scroll lock) in the table.