Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix demo seed conflicting with dev seed #9087

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Dec 16, 2024

We have conflicts which prevents us from running demo seed command after a database-reset or/and if dev seed has already been populated. This is because we are trying to create Tim user twice (but due to the insert()...onConflict() in the seed creation, it does not create the second one), for seed-dev and seed-demo .

This PR fixes that by using the same user id, allowing us to use the same Tim apple for both dev/demo seeds

Test
Screenshot 2024-12-16 at 15 36 56
Screenshot 2024-12-16 at 15 37 17

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified the UUID for the TIM demo user to prevent conflicts when running demo seed commands after dev seed population.

  • Changed TIM's UUID in /packages/twenty-server/src/database/typeorm-seeds/core/demo/users.ts from '20202020-7169-42cf-bc47-1cfef15264b9' to '20202020-9e3b-46d4-a556-88b9ddc2b034' to match dev seed ID pattern
  • Maintains consistent '20202020' prefix pattern with other demo user IDs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ijreilly ijreilly merged commit 5d51a82 into main Dec 16, 2024
19 checks passed
@ijreilly ijreilly deleted the c--fix-demo-seed-conflict-with-dev-seed branch December 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants