Fix Tasks/Notes created with null position #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e + remove sync-metadata health-check
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements comprehensive changes to fix null position handling in Tasks and Notes across the application. Here's a summary of the key changes:
- Added new
0.40upgrade command with record position backfill functionality and forced metadata sync - Made position fields non-nullable with default value 0 across all workspace entities (Tasks, Notes, Companies, etc.)
- Centralized error handling by moving try/catch blocks from resolver factories to graphql-query-runner level
- Removed unused record position backfill job in favor of direct command execution
- Improved sync-metadata performance by skipping health checks when using force mode
The changes look well-structured and address the core issues while improving overall code organization and performance.
53 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile
...y-server/src/database/commands/upgrade-version/0-40/0-40-record-position-backfill.command.ts
Show resolved
Hide resolved
...y-server/src/database/commands/upgrade-version/0-40/0-40-record-position-backfill.command.ts
Show resolved
Hide resolved
...ages/twenty-server/src/database/commands/upgrade-version/0-40/0-40-upgrade-version.module.ts
Outdated
Show resolved
Hide resolved
...ges/twenty-server/src/database/commands/upgrade-version/0-40/0-40-upgrade-version.command.ts
Show resolved
Hide resolved
...wenty-server/src/engine/api/graphql/graphql-query-runner/interfaces/base-resolver-service.ts
Show resolved
Hide resolved
...engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command.ts
Show resolved
Hide resolved
...c/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts
Outdated
Show resolved
Hide resolved
...c/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts
Show resolved
Hide resolved
magrinj
reviewed
Dec 16, 2024
packages/twenty-front/src/modules/activities/hooks/useOpenCreateActivityDrawer.ts
Show resolved
Hide resolved
|
|
||
| const graphqlQuerySelectedFieldsResult = | ||
| graphqlQueryParser.parseSelectedFields( | ||
| const resultWithGetters = await this.queryResultGettersFactory.create( |
There was a problem hiding this comment.
I've take a look inside QueryRunnerArgsFactory, create function return an any type, it seems a bit old, but we can definitely properly type this with function override or union, any shouldn't used
...gine/api/graphql/graphql-query-runner/resolvers/graphql-query-create-one-resolver.service.ts
Show resolved
Hide resolved
...-server/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts
Show resolved
Hide resolved
...r/src/engine/api/graphql/workspace-query-runner/services/record-position-backfill-service.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8810
Fixes #5268
Fixes #8971