Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links composite field #9059

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Add links composite field #9059

merged 3 commits into from
Dec 13, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Dec 13, 2024

  • only primary links for now
  • need for a global strat for validation. This will come later

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Adds a new links composite field type with primary link functionality, allowing users to input and manage link labels and URLs within forms.

  • Implements FormLinksFieldInput in /packages/twenty-front/src/modules/object-record/record-field/form-types/components/FormLinksFieldInput.tsx with label and URL input fields
  • Adds links field type support in /packages/twenty-front/src/modules/object-record/record-field/components/FormFieldInput.tsx with proper type handling
  • Contains spelling error "Domaine" in Storybook example that should be corrected
  • Missing URL validation in FormLinksFieldInput component, needed to prevent invalid links
  • Example URL in Storybook story uses incomplete format ("www.google.com" without protocol)

3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with greptile comment, but nothing blocking for me. Good job

@thomtrp thomtrp enabled auto-merge (squash) December 13, 2024 15:51
@thomtrp thomtrp merged commit 32e7eb7 into main Dec 13, 2024
19 checks passed
@thomtrp thomtrp deleted the tt-add-links-composite-field branch December 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants