Fix broken chips on timelin eActivity on show pages #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
approved these changes
Dec 13, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR replaces basePathToShowPage with labelIdentifierLink in FieldContext to fix broken chips in timeline activities on show pages, improving navigation and linking behavior across components.
- Modifies
packages/twenty-front/src/modules/object-record/record-field/contexts/FieldContext.tsto uselabelIdentifierLinkinstead ofbasePathToShowPage - Updates
ChipFieldDisplaycomponent to uselabelIdentifierLinkfor proper chip navigation - Simplifies
RecordIndexRecordChipby removinguseRecordIndexContextOrThrowand using directtoprop - Adds
labelIdentifierLinktouseChipFieldDisplayhook for consistent link handling - Removes redundant path generation in
RecordTableCellFieldContextWrapperin favor ofindexIdentifierUrl
11 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const { columnDefinition } = useContext(RecordTableCellContext); | ||
|
|
||
| const { recordId, pathToShowPage } = useRecordTableRowContextOrThrow(); | ||
| const { recordId } = useRecordTableRowContextOrThrow(); |
There was a problem hiding this comment.
style: pathToShowPage is destructured but never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using RecordIndexContext in FieldDisplays components which is wrong as the FieldDisplays could be used in locations not providing this context (not being indexes pages).
Instead, we are passing it within FieldContext which the context that will always be there for FieldDisplays and we need indexes to fill this FieldContext with their RecordIndexContext value when needed