-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: record group insert at bottom when created #9053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies record insertion behavior in record groups to add new records at the bottom of the visible page instead of the top, addressing issue #9050.
- Modified position calculation in
useUpsertTableRecordInGroup.ts
to place new records after the last record with a +0.0001 position increment - Reordered components in
RecordTableRecordGroupRows.tsx
to placeRecordTablePendingRecordGroupRow
before load more section - Added support for 'first', 'last', and numeric positioning in
triggerCreateRecordsOptimisticEffect.ts
for flexible record insertion - Removed pending record check in
RecordTableRecordGroupSectionAddNew.tsx
to allow consecutive record additions - Fixed syntax error in
graphql-query-create-one-resolver.service.ts
by removing erroneous 'async;' line
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...y-front/src/modules/object-record/record-table/hooks/internal/useUpsertTableRecordInGroup.ts
Show resolved
Hide resolved
...nty-front/src/modules/apollo/optimistic-effect/utils/triggerCreateRecordsOptimisticEffect.ts
Show resolved
Hide resolved
...nty-front/src/modules/apollo/optimistic-effect/utils/triggerCreateRecordsOptimisticEffect.ts
Outdated
Show resolved
Hide resolved
...gine/api/graphql/graphql-query-runner/resolvers/graphql-query-create-one-resolver.service.ts
Show resolved
Hide resolved
@magrinj tested your PR, looks better and better! Found a bug: if I have many pages, I add a record and then click on load more, my record is present twice which makes sense! We should either:
|
Fix #9050
When we add a new record in a record group this one should be added at them bottom.